Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: Use a helper during e2e test to create different prometheus instances when they are needed #2669

Merged
merged 8 commits into from
Feb 28, 2022
Merged

fix: Use a helper during e2e test to create different prometheus instances when they are needed #2669

merged 8 commits into from
Feb 28, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Feb 24, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado jorge.turrado@docplanner.com

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Related #2584

@JorTurFer JorTurFer requested a review from a team as a code owner February 24, 2022 17:09
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 24, 2022 •
edited by github-actions bot
Loading

/run-e2e pr*.test.ts
Update: You can check the progres here

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 24, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
Copy link
Member Author

the failing test is azure-queue test, so this PR is mergeable (I'm working on that test in other PR)

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 26, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

Jorge Turrado added 7 commits February 26, 2022 23:50
@JorTurFer
Add helper
a7613cd 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Update prometheus scaler e2e to use new helper
b7dd642 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Update predictkube e2e test to use the new helper
020f9bc 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Update changelog
ca79eee 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Fix styles
a08f27e 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Update argo-rollouts e2e tests
0ec2621 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Remove unused variable
db6af66 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Copy link
Member Author

Again scalers/azure-queue.test.ts has been the problem

tomkerkhove
tomkerkhove approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👌

@JorTurFer
Apply feedback
f0da258 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 28, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer JorTurFer merged commit cf26748 into kedacore:main Feb 28, 2022
@JorTurFer JorTurFer deleted the prometheus_helper branch February 28, 2022 09:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JorTurFer @tomkerkhove