Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Add step in makefile to get the cluster context and use it to delete namespaces #2683

Merged
merged 3 commits into from
Mar 1, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Feb 28, 2022

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

This PR extracts the context recovering and use it for e2e test and namespace deletion. This solves the problem of failing the CI before recovering the cluster context

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2584

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner February 28, 2022 20:24
@JorTurFer JorTurFer marked this pull request as draft February 28, 2022 20:25
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer marked this pull request as ready for review February 28, 2022 20:33
@JorTurFer JorTurFer changed the title fix: Add step in makefile to get the cluster context fix: Add step in makefile to get the cluster context and use it to delete namespaces Feb 28, 2022
@zroubalik zroubalik merged commit 4e6be90 into kedacore:main Mar 1, 2022
@JorTurFer JorTurFer deleted the fix_clean branch March 1, 2022 11:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve e2e tests to always cleanup resources in cluster
2 participants