Add managed identity client id parameter to data explorer scaler #2822
Conversation
yardenoff
force-pushed
the
yasiboni/fixKustoManagedIdentityE2eBug
branch
from
576daaa to
37bebc1
Compare
|
Can you please add env var |
| @@ -5,6 +5,7 @@ import test from 'ava' | |||
|
|
|||
| const dataExplorerDb = process.env['AZURE_DATA_EXPLORER_DB'] | |||
| const dataExplorerEndpoint = process.env['AZURE_DATA_EXPLORER_ENDPOINT'] | |||
| const msiClientId = process.env['AZURE_MSI_CLIENT_ID'] | |||
There was a problem hiding this comment.
We should add this env variable to worklflows under .github/workflows, eg.
keda/.github/workflows/pr-e2e.yml
Line 69 in 1331324
There was a problem hiding this comment.
@JorTurFer @tomkerkhove we need to add this variable to GH secrets
There was a problem hiding this comment.
As far as I can see, we don't have AAD-Pod-Identity deployed in the clusters (nor in nightly nor pr) and I cannot do it.
If we need it, @tomkerkhove or @ahmelsayed have to do it and create the proper identities
There was a problem hiding this comment.
As far as I can see, we don't have AAD-Pod-Identity deployed in the clusters (nor in nightly nor pr) and I cannot do it. If we need it, @tomkerkhove or @ahmelsayed have to do it and create the proper identities
@JorTurFer - Are You sure you don't have aad-pod-identity in your e2e cluster? because one of the e2e scenarios of azure-data-explorer scaler is relying on that and it completed successfully until the bug this pr is going to fix
Signed-off-by: Yarden Siboni <yasiboni@microsoft.com>
Signed-off-by: Yarden Siboni <yasiboni@microsoft.com>
Signed-off-by: Yarden Siboni <yasiboni@microsoft.com>
Signed-off-by: Yarden Siboni <yasiboni@microsoft.com>
yardenoff
force-pushed
the
yasiboni/fixKustoManagedIdentityE2eBug
branch
from
346575b to
384871f
Compare
There was a problem hiding this comment.
While the intention here is good, it's only scoped to Azure Data Explorer and think we should abandon it in favor of #2741 which has a nicer fix.
Agree, closing this pr. |
Signed-off-by: Yarden Siboni yardensib@gmail.com
Add support for new parameter in trigger metadata for Azure Data Explorer scaler -
msiClientId.This parameter is mandatory when user choose to authenticate through pod identity.
keda-docs PR: kedacore/keda-docs#731
Checklist
Fixes #2770