Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Non-public cloud support for Azure Data Explorer scaler. #2839

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

v-shenoy
Copy link
Contributor

Support for cloud parameter in Data Explorer trigger metadata.

Sample ScaledObject definition -

apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: kusto-so
spec:
  scaleTargetRef: 
    name: kusto-deployment
  pollingInterval: 10
  cooldownPeriod: 30
  minReplicaCount: 0
  maxReplicaCount: 2
  triggers:
    - type: azure-data-explorer
      metadata:
        tenantId: <tenant-id>
        clientId: <client-id>
        clientSecret: <client-secret>
        endpoint: <endpoint>
        databaseName: <database>
        cloud: "private" # Optional
        activeDirectoryEndpoint: <active-directory-endpoint> # Required when cloud = private
        query: <query>
        threshold: <threshold>

Documentation PR - kedacore/keda-docs#736

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2734

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy v-shenoy requested a review from a team as a code owner March 29, 2022 05:24
@v-shenoy v-shenoy changed the title Npc data explorer Non-public cloud support for Azure Data Explorer scaler. Mar 29, 2022
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks!

@JorTurFer JorTurFer merged commit e60a4dd into kedacore:main Mar 29, 2022
@v-shenoy v-shenoy deleted the npc-data-explorer branch March 29, 2022 21:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support non-public clouds for Azure Data Explorer
2 participants