fix(kafka-scaler): return error if partition processing fails #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e kafka* |
zroubalik
reviewed
Jan 20, 2023
|
@sdomme could you please fix the DCO? then we can go ahead and merge this The fix instructions can be found in the Details: https://github.com/kedacore/keda/pull/4149/checks?check_run_id=10870127333 |
sdomme
force-pushed
the
fix/return-error-on-partition-fail
branch
2 times, most recently
from
888f59d to
8a298df
Compare
Signed-off-by: Sergej Domme <sergej.domme@idealo.de>
Signed-off-by: Sergej Domme <sergej.domme@idealo.de>
sdomme
force-pushed
the
fix/return-error-on-partition-fail
branch
from
8a298df to
46cd836
Compare
|
@zroubalik Is it somehow stuck in a workflow? Can I do something here? |
|
/run-e2e kafka* |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergej Domme sergej.domme@idealo.de
This fix allows to return an error during the partition iteration in case the process of getting the lag from the partition fails finding the block.
Checklist
Fixes #4098