fix(aws-sqs): Respect scaleOnInFlight value
#4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
|
/run-e2e aws* |
JorTurFer
changed the title
scaleOnInFlight value
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
|
/run-e2e aws* |
xoanmm
pushed a commit
to xoanmm/keda
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Apr 13, 2023
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Apr 13, 2023
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
JorTurFer
added a commit
that referenced
this pull request
Apr 13, 2023
…<Jorge_turrado@hotmail.es> Co-authored-by: Andy Ward <mortx@toothless.eldarrin.io> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com> Co-authored-by: Eugene Lugovtsov <34510252+EugeneLugovtsov@users.noreply.github.com> fix(aws-sqs): Respect `scaleOnInFlight` value (#4358) fix odd number of arguments passed as key-value pairs for logging (#4369) fix: Azure Pipelines Scaler uses correct endpoint when demands are set (#4387) (#4401) fix: respect all required demands in azure pipeline scaler (#4405) fix: Allow to remove the finalizer even if the ScaledObject isn't valid (#4397) * Drop a transitive dependency on bou.ke/monkey (#4366) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix(aws-sqs): Respect `scaleOnInFlight` value (#4358) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * chore: update supported versions in the welcome message (#4360) Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix odd number of arguments passed as key-value pairs for logging (#4369) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix: Azure Pipelines Scaler uses correct endpoint when demands are set (#4387) (#4401) Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Andy Ward <mortx@toothless.eldarrin.io> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix: respect all required demands in azure pipeline scaler (#4405) Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix: Allow to remove the finalizer even if the ScaledObject isn't valid (#4397) Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * update changelog Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> --------- Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com> Co-authored-by: Andy Ward <mortx@toothless.eldarrin.io> Co-authored-by: Eugene Lugovtsov <34510252+EugeneLugovtsov@users.noreply.github.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
awsSqsQueueMetricNamesvariable was defined at package level and it was modified based on trigger parameters.This makes it shared across all the ScaledObjects, which isn't correct
Checklist
Fixes #4276