fix(config/grafana): use range for HPA metrics #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use range instead of instant for HPA current/max replicas (time based). Right now, we are using the instant selector, which given that the panel should be time-based (as per the title), it should use a range selector, thus getting all metrics in a given timeframe. Also, moved from bars to lines because bars are hard to visualize using ranges containing several days worth of data. Signed-off-by: Ricardo Ribeiro <j.ribeiro.fafe@gmail.com>
2 tasks
tomkerkhove
approved these changes
May 2, 2023
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
May 2, 2023
geoffrey1330
pushed a commit
to geoffrey1330/keda
that referenced
this pull request
Oct 4, 2023
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
rangeinstead ofinstantfor HPA current/max replicas (time based).Right now, we are using the
instantselector, which given that the panel should be time-based (as per the title), it should use arangeselector, thus getting all metrics in a given timeframe, not just the last data point.Also, moved from bars to lines because bars are hard to visualize using
rangescontaining several days worth of data.Before:
After:
Checklist