Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecate Stan scaler #6363

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Deprecate Stan scaler #6363

merged 1 commit into from
Nov 26, 2024

Conversation

rickbrouwer
Copy link
Contributor

Deprecate the NATS Streaming Server (aka Stan)

Checklist

Fixes #6362

Docs kedacore/keda-docs#1503

@rickbrouwer rickbrouwer requested a review from a team as a code owner November 25, 2024 16:08
@rickbrouwer
Copy link
Contributor Author

rickbrouwer commented Nov 25, 2024

Since I don't have the rights, can a maintainer can perform the following actions:

Create a representing issue that is used for tracking breaking changes for our upcoming major version.
Because of that, it must be labeled with breaking-change and a label to indicate the version in which it will be removed, removal:keda-v2.19

Please also an announcement on GitHub Discussions

@rickbrouwer rickbrouwer force-pushed the stan branch 2 times, most recently from be0beaa to 70a2ab9 Compare November 25, 2024 16:37
pkg/scalers/stan_scaler.go Outdated Show resolved Hide resolved
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
@wozniakjan
Copy link
Member

/skip-e2e
this is just a deprecation notice, no need for e2es

@wozniakjan wozniakjan merged commit 29400ed into kedacore:main Nov 26, 2024
20 checks passed
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
robpickerill pushed a commit to robpickerill/keda that referenced this pull request Nov 30, 2024
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
rickbrouwer added a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
rickbrouwer added a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
rickbrouwer added a commit to rickbrouwer/keda that referenced this pull request Dec 4, 2024
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
@rickbrouwer rickbrouwer deleted the stan branch December 5, 2024 11:51
ctccxxd pushed a commit to ctccxxd/keda that referenced this pull request Dec 10, 2024
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
rickbrouwer added a commit to rickbrouwer/keda that referenced this pull request Jan 2, 2025
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate NATS Streaming Server (aka Stan)
3 participants