-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[v2] removed deprecated brokerList #882
Conversation
Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog fix needed
CHANGELOG.md
Outdated
@@ -81,7 +79,7 @@ None. | |||
### Improvements | |||
|
|||
- Make targetQueryValue configurable in postgreSQL scaler ([#643](https://github.com/kedacore/keda/pull/643)) | |||
- Added bootstrapServers to deprecate brokerList ([#621](https://github.com/kedacore/keda/pull/621)) | |||
- Removed deprecated brokerList ([#621](https://github.com/kedacore/keda/pull/621)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in section ## v2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it should point to this PR
Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
Signed-off-by: Samuel Macko <samuel.macko.sm@gmail.com>
Fixes: #632
Signed-off-by: Samuel Macko samuel.macko.sm@gmail.com
Provide a description of what has been changed
Checklist
Fixes #