Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[v2] Unique MetricName for each Trigger in ScaledObject #966

Merged
merged 3 commits into from
Aug 5, 2020
Merged

[v2] Unique MetricName for each Trigger in ScaledObject #966

merged 3 commits into from
Aug 5, 2020

Conversation

samuelmacko
Copy link
Contributor

@samuelmacko samuelmacko commented Aug 3, 2020

Added unique name for every scaler. Multiple metrics for one ScaledObject can be used.

Checklist

Fixes #733

Signed-off-by: samuelmacko <samuel.macko.sm@gmail.com>
Signed-off-by: samuelmacko <samuel.macko.sm@gmail.com>
@zroubalik zroubalik changed the title Unique name [v2] Unique name Aug 3, 2020
@zroubalik zroubalik changed the title [v2] Unique name [v2] Unique MetricName for each Trigger in ScaledObject Aug 3, 2020
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just very minor nits

Copy link
Contributor

@ahmelsayed ahmelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMT

Signed-off-by: samuelmacko <samuel.macko.sm@gmail.com>
@zroubalik zroubalik merged commit a9f70e3 into kedacore:v2 Aug 5, 2020
zroubalik pushed a commit that referenced this pull request Aug 6, 2020
Signed-off-by: samuelmacko <samuel.macko.sm@gmail.com>
@ahmelsayed ahmelsayed mentioned this pull request Aug 11, 2020
3 tasks
@samuelmacko samuelmacko deleted the unique-name branch August 13, 2020 07:39
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants