This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Default value having colon can be parsed now #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier if the value to be substituted looked like this: ``` [[ APP_URL:web:8080 ]] ``` then it used to fail, but with this commit if default value is provided with colons then it works fine.
surajssd
force-pushed
the
default-value-token
branch
from
785bb3c to
5f9bf2a
Compare
|
thanks @surajssd ! I just tried it locally and it worked fine for |
kadel
approved these changes
Apr 4, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier if the value to be substituted looked like this:
then it used to fail, but with this commit if default value is provided
with colons then it works fine.