Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TOTP icon improvements #786

Merged
merged 1 commit into from
Feb 25, 2020
Merged

TOTP icon improvements #786

merged 1 commit into from
Feb 25, 2020

Conversation

varjolintu
Copy link
Member

Ignores TOTP field icons when input field type is password or input field name/id begins with zip/postal and ends with code.

Fixes #768.

@varjolintu varjolintu added this to the 1.5.5 milestone Feb 25, 2020
@droidmonkey
Copy link
Member

I have seen some TOTP fields that are password fields, for some dumb reason. I cannot recall an example right now, but be prepared if this breaks someone's workflow. I think the password field might be too broad of a discriminator.

@varjolintu
Copy link
Member Author

@droidmonkey I'm aware of that. Sadly it's expected that something always breaks because the sites just doesn't use the standard option(s) for these.

@varjolintu varjolintu merged commit b08966c into develop Feb 25, 2020
@varjolintu varjolintu deleted the fix/totp_icon_fixes branch February 25, 2020 16:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: No "Fill TOTP from KeePassXC" in postal/zip_code fields
2 participants