Database file refresh doesn't occur when entry or group is being edited #8545
Comments
|
This is a complicated problem because we don't want to refresh the database while you are actively editing it, however our file manager should have seen that the underlying file changed prior to saving and merge in those changes first. That clearly failed so there is a bug here or the style of network share being used has a cache mechanism that prevents this detection. |
droidmonkey
changed the title
|
I should add, that this is happening with both clients and server on the same LAN.
Standard Windows share.
You mention merge - I have experienced multiple times (while connected via VPN) that I was asked to confirm merge. Regardless of my choice (merge or discard) it always ended with application freeze idefinitely.
Thanks
Ludek.
|
|
I just fixed the above freeze problem. |
This was referenced Mar 18, 2024
pull bot
pushed a commit
to Graysonbarton/keepassxc
that referenced
this issue
Feb 1, 2025
…keepassxreboot#10612) Fixes keepassxreboot#5290 Fixes keepassxreboot#9062 Fixes keepassxreboot#8545 * Fix data loss on failed reload - External modifications to the db file can no longer be missed. - Fixed dialogFinished signal of DatabaseOpenDialog was not emitted when dialog was closed via the 'X' (close) button - For reloading with a modified db, an additional choice has been added to allow the user to ignore the changes in the file on disk. - User is now presented with an unlock database dialog if reload fails to open the db automatically. For example when the user removed the YubiKey, failed to touch the YubiKey within the timeout period, or db pw has been changed. - Mark db as modified when db file is gone or invalid. - Prevent saving when db is being reloaded - If merge is triggered by a save action, continue on with the save action after the user makes their choice --------- Co-authored-by: vuurvlieg <vuurvli3g@protonmail.com> Co-authored-by: Jonathan White <support@dmapps.us>
droidmonkey
added a commit
that referenced
this issue
Feb 2, 2025
…#10612) Fixes #5290 Fixes #9062 Fixes #8545 * Fix data loss on failed reload - External modifications to the db file can no longer be missed. - Fixed dialogFinished signal of DatabaseOpenDialog was not emitted when dialog was closed via the 'X' (close) button - For reloading with a modified db, an additional choice has been added to allow the user to ignore the changes in the file on disk. - User is now presented with an unlock database dialog if reload fails to open the db automatically. For example when the user removed the YubiKey, failed to touch the YubiKey within the timeout period, or db pw has been changed. - Mark db as modified when db file is gone or invalid. - Prevent saving when db is being reloaded - If merge is triggered by a save action, continue on with the save action after the user makes their choice --------- Co-authored-by: vuurvlieg <vuurvli3g@protonmail.com> Co-authored-by: Jonathan White <support@dmapps.us>
pull bot
pushed a commit
to blog2i2j/keepassxreboot.._..keepassxc
that referenced
this issue
Feb 22, 2025
…keepassxreboot#10612) Fixes keepassxreboot#5290 Fixes keepassxreboot#9062 Fixes keepassxreboot#8545 * Fix data loss on failed reload - External modifications to the db file can no longer be missed. - Fixed dialogFinished signal of DatabaseOpenDialog was not emitted when dialog was closed via the 'X' (close) button - For reloading with a modified db, an additional choice has been added to allow the user to ignore the changes in the file on disk. - User is now presented with an unlock database dialog if reload fails to open the db automatically. For example when the user removed the YubiKey, failed to touch the YubiKey within the timeout period, or db pw has been changed. - Mark db as modified when db file is gone or invalid. - Prevent saving when db is being reloaded - If merge is triggered by a save action, continue on with the save action after the user makes their choice --------- Co-authored-by: vuurvlieg <vuurvli3g@protonmail.com> Co-authored-by: Jonathan White <support@dmapps.us>
jopamo
pushed a commit
to jopamo/keepassxc
that referenced
this issue
Mar 1, 2025
…keepassxreboot#10612) Fixes keepassxreboot#5290 Fixes keepassxreboot#9062 Fixes keepassxreboot#8545 * Fix data loss on failed reload - External modifications to the db file can no longer be missed. - Fixed dialogFinished signal of DatabaseOpenDialog was not emitted when dialog was closed via the 'X' (close) button - For reloading with a modified db, an additional choice has been added to allow the user to ignore the changes in the file on disk. - User is now presented with an unlock database dialog if reload fails to open the db automatically. For example when the user removed the YubiKey, failed to touch the YubiKey within the timeout period, or db pw has been changed. - Mark db as modified when db file is gone or invalid. - Prevent saving when db is being reloaded - If merge is triggered by a save action, continue on with the save action after the user makes their choice --------- Co-authored-by: vuurvlieg <vuurvli3g@protonmail.com> Co-authored-by: Jonathan White <support@dmapps.us>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Overview
We are using Windows version KeePassXC 2.7.1. Database is located on network share. When two users are performing edit on the database (different entries) in the same time, changes of the one that save his edit first are lost.
Steps to Reproduce
Expected Behavior
I expect any edits not to disappear from database used in network shared environment.
Actual Behavior
When I do not edit database and other user save his changes to the database I can see the refresh on my side. I suppose his changes are synced with my instance of the application and all is well.
However if I have open any entry and I am editing it, in the time he does his save, the refresh apparently does not take place and after I save my changes to the database, his changes are overwritten by my, now outdated version.
Context
KeePassXC - Verze 2.7.1
Revision: 5916a8f
Operating System: Windows 10 + Windows Server 2016 as fileserver
Desktop Env:
Windowing System:
The text was updated successfully, but these errors were encountered: