Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix database password clearing when modifying key file / hardware key #11001

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

c4rlo
Copy link
Contributor

@c4rlo c4rlo commented Jun 28, 2024

Fix a bug in the database key settings dialog, where it was previously always incorrectly applying an empty password if the password was not changed but some other change was made (e.g. adding or removing a key file).

Fixes #10996.

I think this bug may have been introduced in #10821, specifically the change to PasswordEditWidget::isEmpty() here.

Testing strategy

Manual testing.

I can try to add an automated test if desired.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

Fix a bug in the database key settings dialog, where it was previously
always incorrectly applying an empty password if the password was not
changed but some other change was made (e.g. adding or removing a key
file).
@droidmonkey
Copy link
Member

Ugh and I tested this too... must have screwed myself over. I recommend also adding to the GUI tests for this widget to verify this situation doesn't occur in the future.

@droidmonkey droidmonkey added this to the v2.7.10 milestone Jun 28, 2024
@droidmonkey droidmonkey changed the title Database key settings: fix UI bug Fix database password clearing when modifying key file / hardware key Jun 28, 2024
@droidmonkey
Copy link
Member

droidmonkey commented Jun 28, 2024

@phoerious this bug is a breaker... it could cause the end user to be forced into a no-password database credential. They basically have to edit the database password and set it to the original value to change the key file or hardware key.

@droidmonkey droidmonkey merged commit 8544590 into keepassxreboot:develop Jun 29, 2024
11 checks passed
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Jul 1, 2024
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
@jgehrcke
Copy link

jgehrcke commented Feb 9, 2025

Just ran into this -- when will we have a new release?

Thanks for all the work on this piece of software. I have so far been using the original with the Mono runtime on Linux (for more than a decade) and am now exploring to using this here instead on Linux. More or less good impression so far, but to be quite honest I wish there were more frequent releases.

@droidmonkey
Copy link
Member

It's in immediate pipeline right now.

@jgehrcke
Copy link

Thank you so much. Great, important work.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
high priority 🚨 pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing a database's key file removes the password
4 participants