Support tearing off tags menu #11652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
feature: Tags
pr: new feature
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11652 +/- ##
===========================================
- Coverage 63.66% 63.61% -0.05%
===========================================
Files 367 367
Lines 38868 38886 +18
===========================================
- Hits 24745 24737 -8
- Misses 14123 14149 +26 ☔ View full report in Codecov by Sentry. |
droidmonkey
force-pushed
the
feature/tags-tearoff
branch
from
d8d003c to
bcb0437
Compare
|
@droidmonkey, In Linux, clicking on a tag from the context menu results in a segmentation fault. |
|
I'm also having |
varjolintu
reviewed
Jan 13, 2025
droidmonkey
force-pushed
the
feature/tags-tearoff
branch
from
bcb0437 to
b946aca
Compare
droidmonkey
force-pushed
the
feature/tags-tearoff
branch
from
b946aca to
f0be060
Compare
varjolintu
approved these changes
Feb 17, 2025
phoerious
approved these changes
Feb 22, 2025
* Closes #11649 - tags menu can be torn off to set and unset tags without having to dive into the context menu every time. * Tags menu will hide when database is locked or view is switched away from the main database view (eg, settings)
droidmonkey
force-pushed
the
feature/tags-tearoff
branch
from
f0be060 to
e233b74
Compare
droidmonkey
added a commit
that referenced
this pull request
Feb 23, 2025
* Support tearing off tags menu * Closes #11649 - tags menu can be torn off to set and unset tags without having to dive into the context menu every time. * Tags menu will hide when database is locked or view is switched away from the main database view (eg, settings)
pull bot
pushed a commit
to blog2i2j/keepassxreboot.._..keepassxc
that referenced
this pull request
Feb 23, 2025
* Support tearing off tags menu * Closes keepassxreboot#11649 - tags menu can be torn off to set and unset tags without having to dive into the context menu every time. * Tags menu will hide when database is locked or view is switched away from the main database view (eg, settings)
jopamo
pushed a commit
to jopamo/keepassxc
that referenced
this pull request
Mar 1, 2025
* Support tearing off tags menu * Closes keepassxreboot#11649 - tags menu can be torn off to set and unset tags without having to dive into the context menu every time. * Tags menu will hide when database is locked or view is switched away from the main database view (eg, settings)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Tags multiselect right click context menu #11649 - tags menu can be torn off to set and unset tags without having to dive into the context menu every time.
Tags menu will hide when database is locked or view is switched away from the main database view (eg, settings)
Screenshots
See #11649
Testing strategy
Tested on windows manually
Type of change