Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert DatabaseOpenDialog to be always on top on Linux #7771

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

droidmonkey
Copy link
Member

Fixes regression due to issues with dialogs appearing above other windows on some Linux Desktop Envs.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

Fixes regression due to issues with dialogs appearing above other windows on some Linux Desktop Envs.
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

Merging #7771 (262b517) into develop (2b8d670) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #7771      +/-   ##
===========================================
- Coverage    64.29%   64.29%   -0.00%     
===========================================
  Files          339      339              
  Lines        43451    43455       +4     
===========================================
+ Hits         27936    27938       +2     
- Misses       15515    15517       +2     
Impacted Files Coverage Δ
src/gui/DatabaseOpenDialog.cpp 60.75% <100.00%> (+1.52%) ⬆️
src/core/Entry.cpp 82.59% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8d670...262b517. Read the comment docs.

Copy link
Member

@phoerious phoerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugly, but whatever. Will revisit when we have quick unlock.

@droidmonkey droidmonkey merged commit d8da81d into develop Apr 2, 2022
@droidmonkey droidmonkey deleted the hotfix/db-dialog-linux branch April 2, 2022 16:50
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Apr 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
platform: Linux - KDE pr: backported Pull request backported to previous release regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants