Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FdoSecrets: do not share entry <-> item property by multiple unlock prompts #7786

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

Aetf
Copy link
Contributor

@Aetf Aetf commented Apr 4, 2022

Fixes #7753

Testing strategy

Tested manually. Existing unit tests pass.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #7786 (79e6d24) into develop (7cd824a) will decrease coverage by 0.03%.
The diff coverage is 72.73%.

@@             Coverage Diff             @@
##           develop    #7786      +/-   ##
===========================================
- Coverage    64.32%   64.29%   -0.03%     
===========================================
  Files          339      339              
  Lines        43429    43430       +1     
===========================================
- Hits         27933    27921      -12     
- Misses       15496    15509      +13     
Impacted Files Coverage Δ
src/fdosecrets/objects/Prompt.h 87.50% <ø> (ø)
src/fdosecrets/objects/Prompt.cpp 82.06% <72.73%> (-0.61%) ⬇️
...rc/fdosecrets/widgets/SettingsWidgetFdoSecrets.cpp 56.06% <0.00%> (-3.03%) ⬇️
src/fdosecrets/dbus/DBusMgr.cpp 52.20% <0.00%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd824a...79e6d24. Read the comment docs.

@Aetf Aetf requested a review from droidmonkey April 4, 2022 20:45
@droidmonkey droidmonkey added this to the v2.7.1 milestone Apr 4, 2022
@droidmonkey droidmonkey force-pushed the fix/multiple-unlock-crash branch from 30a68e4 to 79e6d24 Compare April 4, 2022 23:20
@droidmonkey droidmonkey merged commit 6b0eeb9 into keepassxreboot:develop Apr 5, 2022
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Apr 6, 2022
@Aetf Aetf deleted the fix/multiple-unlock-crash branch December 5, 2022 08:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
crash 💥 feature: Secret Service pr: backported Pull request backported to previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in fdosecrets/objects/Prompt.cpp
3 participants