Improve duplicate URL warning #9635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could extend this with adding a comparison where URL's without a path/fragments/ports etc. are identical if there's just a domain and a possible |
droidmonkey
approved these changes
Jul 31, 2023
|
Let's remove any trailing slashes from URL's when doing comparisons. We should also be trimming user entered data as well (remove spaces at beginning and end) prior to accepting the URL. |
Fixed it. But it's kind of hacky. Qt's URL comparison does not work correctly even when trying to strip trailing slashes if one of the URL's have |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
droidmonkey
force-pushed
the
fix/duplicate_entry_url
branch
from
1d6f093 to
1ce9ebe
Compare
droidmonkey
pushed a commit
that referenced
this pull request
Aug 14, 2023
Co-authored-by: varjolintu <sami.vanttinen@protonmail.com>
libf-de
pushed a commit
to libf-de/keepassxc-secretservice-dbus
that referenced
this pull request
Aug 16, 2023
Release 2.7.6 Changes - Significant improvement to visual when drag/drop entries [keepassxreboot#9698] - Automatically prompt for Quick Unlock when showing unlock dialog [keepassxreboot#9697] - Improve colorful lock icon and fix file MIME icon on KDE [keepassxreboot#9632] - Ability to search by entry UUID [keepassxreboot#9571] - Add challenge-response support for NitroKey 3 [keepassxreboot#9631] - Auto-Type: Disable entry level Auto-Type when disabled at group/entry [keepassxreboot#9672] - Browser: Show warning when adding duplicate URL's to entry [keepassxreboot#9588][keepassxreboot#9635] - Browser: Improve error message when proxy cannot be found [keepassxreboot#9385] Fixes - Fix crash on exit on macOS [keepassxreboot#9620] - Fix crash on search if entry doesn't have a group [keepassxreboot#9633] - Fix several issues with Quick Unlock [keepassxreboot#9697] - Enable save button when not auto-saving non-data changes [keepassxreboot#9634] - Several UI/UX fixes [keepassxreboot#9647] - Move toolbar back to top of window when disabling movement [keepassxreboot#9699] - Browser: Fix closing password generator dialog with X button [keepassxreboot#9636] - Browser: Fix handling of expired credentials [keepassxreboot#9595] - Windows: Prevent white flicker when launching application [keepassxreboot#9637] - Linux: Fix warning message about allow screencapture [keepassxreboot#9638] - FdoSecrets: Fix access confirmation dialog showing even when disabled [keepassxreboot#9690] # -----BEGIN PGP SIGNATURE----- # # iQJIBAABCAAyFiEE6A9nU7OzJX8m9B8ILPQdKqhDj5kFAmTb/usUHGphbmVrQGtl # ZXBhc3N4Yy5vcmcACgkQLPQdKqhDj5l9vBAAmiCQR+L3ZLVq7CfXK+yOrCr1pV1J # H6znrRe4SC5MR/dyrx+EVbkaPI0aWtW/NWa4REB9BUxkbXKIPy/9M6smj3xkjAqX # YuYThNneRBFns9Rb5RyAIonwEXXmYHAWG2wdRXXFOnsb/Dxy9DYZK6+Ysbj55CQJ # RBJ1y0IKCuajLvENW9zQQ/vTX0oxCQ2F9Fz7aTqGIoxW6NMhjTso7IPvKYWPzbNj # FBOiI4kusL32pT5u+XwSUjmBvXrIEBjETYFTVgqesItAr0dFAgEh8f0jvuy8on8K # ukVzD02JqavkMfwtDsvUVLdVdr1PJMOu4/qDodR1xC39VOjS9LQ6dK8rb/1Q4/MR # cAXjBhNBZ0A5yq9XtdNvl8xYqkvYa/KcFuHUFwBoinLXtKLnh4aswDqk4caNeI4O # O40Nk5J4J6Qgs89XIsQHkXkGTaPxuISHVeFWWqcpX9kRJhtlt5eIS6nDv8nGx8iq # q65NfCldPckgmuIxeCX2lYtxieq09jAhD1/92eXsH1aNkZce4W1UcjGE58cduODd # oXV7VCo0JUzkMky9I9/G+hAqWwLp94D5ewYG8yX2Oz2jwcoWvZSIZ6MtR+2NiYpL # pFSFB/yoqWQOIVc9eHqCQl7rMMK66pJWwu7boxS22/xoNTAfzMwNtp8CmbLpqIhF # 7lPQiiC2DnqfR0E= # =l8kk # -----END PGP SIGNATURE----- # gpg: directory '/home/runner/.gnupg' created # gpg: keybox '/home/runner/.gnupg/pubring.kbx' created # gpg: Signature made Tue Aug 15 22:40:43 2023 UTC # gpg: using RSA key E80F6753B3B3257F26F41F082CF41D2AA8438F99 # gpg: issuer "janek@keepassxc.org" # gpg: Can't check signature: No public key
evur
pushed a commit
to BrokenMS/keepassxc
that referenced
this pull request
Aug 23, 2023
Co-authored-by: varjolintu <sami.vanttinen@protonmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #9588 by deleting a obsolete include and enabling Additional URL list comparison when entry URL is edited but not saved. Previously editing an entry URL on-the-fly didn't update the Additional URL list's duplicate URL warnings.
Fixes #9670.
Testing strategy
Manually.
Type of change