move share structure

implement new functions

apps/PasswordManager/Api/Node/Share/PublicShare.php → apps/PasswordManager/Api/Node/Share/Public/PublicShare.php

@@ -19,15 +19,20 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-namespace KSA\PasswordManager\Api\Node\Share;
+namespace KSA\PasswordManager\Api\Node\Share\Public;
 
+use Doctrine\DBAL\Exception;
+use Keestash\Exception\User\UserNotFoundException;
 use KSA\PasswordManager\Entity\IResponseCodes;
 use KSA\PasswordManager\Entity\Share\NullShare;
 use KSA\PasswordManager\Exception\PasswordManagerException;
 use KSA\PasswordManager\Repository\Node\NodeRepository;
 use KSA\PasswordManager\Repository\PublicShareRepository;
+use KSA\PasswordManager\Service\AccessService;
 use KSA\PasswordManager\Service\Node\Share\ShareService;
 use KSP\Api\IResponse;
+use KSP\Api\IVerb;
+use KSP\Core\DTO\Token\IToken;
 use KSP\Core\Service\HTTP\IResponseService;
 use Laminas\Diactoros\Response\JsonResponse;
 use Psr\Http\Message\ResponseInterface;
@@ -47,10 +52,52 @@ public function __construct(
         , private PublicShareRepository $shareRepository
         , private LoggerInterface       $logger
         , private IResponseService      $responseService
+        , private AccessService         $accessService
     ) {
     }
 
     public function handle(ServerRequestInterface $request): ResponseInterface {
+        return match (strtolower($request->getMethod())) {
+            IVerb::POST => $this->handlePost($request),
+            IVerb::DELETE => $this->handleDelete($request),
+            default => new JsonResponse([], IResponse::BAD_REQUEST),
+        };
+    }
+
+    private function handleDelete(ServerRequestInterface $request): ResponseInterface {
+        try {
+            $parameters = (array) $request->getParsedBody();
+            $shareId    = $parameters["shareId"] ?? null;
+            /** @var IToken $token */
+            $token = $request->getAttribute(IToken::class);
+
+            if ($shareId === null) {
+                return new JsonResponse([], IResponse::BAD_REQUEST);
+            }
+
+            $share = $this->shareRepository->getShareById($shareId);
+
+            if (
+                $share instanceof NullShare
+                || $this->shareService->isExpired($share)
+            ) {
+                return new JsonResponse([], IResponse::NOT_FOUND);
+            }
+
+            $node = $this->nodeRepository->getNode($share->getNodeId(), 0, 0);
+            if (false === $this->accessService->hasAccess($node, $token->getUser())) {
+                return new JsonResponse([], IResponse::FORBIDDEN);
+            }
+
+            $this->shareRepository->remove($share);
+            return new JsonResponse([], IResponse::OK);
+        } catch (Exception|PasswordManagerException|UserNotFoundException $e) {
+            $this->logger->error('error deleting public share', ['e' => $e]);
+            return new JsonResponse([], IResponse::NOT_IMPLEMENTED);
+        }
+    }
+
+    private function handlePost(ServerRequestInterface $request): ResponseInterface {
         try {
 
             $parameters = (array) $request->getParsedBody();

apps/PasswordManager/Api/Node/Share/PublicShareSingle.php → apps/PasswordManager/Api/Node/Share/Public/PublicShareSingle.php

@@ -19,7 +19,7 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-namespace KSA\PasswordManager\Api\Node\Share;
+namespace KSA\PasswordManager\Api\Node\Share\Public;
 
 use DateTimeImmutable;
 use Exception;

apps/PasswordManager/Api/Node/Share/Remove.php → apps/PasswordManager/Api/Node/Share/Regular/Remove.php

@@ -19,7 +19,7 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-namespace KSA\PasswordManager\Api\Node\Share;
+namespace KSA\PasswordManager\Api\Node\Share\Regular;
 
 use Keestash\Api\Response\JsonResponse;
 use KSA\PasswordManager\Repository\Node\NodeRepository;

apps/PasswordManager/Api/Node/Share/Share.php → apps/PasswordManager/Api/Node/Share/Regular/Share.php

@@ -19,7 +19,7 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-namespace KSA\PasswordManager\Api\Node\Share;
+namespace KSA\PasswordManager\Api\Node\Share\Regular;
 
 use Exception;
 use Keestash\Api\Response\JsonResponse;

apps/PasswordManager/Api/Node/Share/ShareableUsers.php → apps/PasswordManager/Api/Node/Share/Regular/ShareableUsers.php

@@ -12,7 +12,7 @@
  * the Keestash software and contains warranty information and liability disclaimers.
  */
 
-namespace KSA\PasswordManager\Api\Node\Share;
+namespace KSA\PasswordManager\Api\Node\Share\Regular;
 
 use doganoo\PHPAlgorithms\Datastructure\Lists\ArrayList\ArrayList;
 use Keestash\Core\DTO\Http\JWT\Audience;

apps/PasswordManager/Exception/Node/Share/ShareException.php

@@ -0,0 +1,28 @@
+<?php
+declare(strict_types=1);
+/**
+ * Keestash
+ *
+ * Copyright (C) <2021> <Dogan Ucar>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published
+ * by the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+namespace KSA\PasswordManager\Exception\Node\Share;
+
+use KSA\PasswordManager\Exception\PasswordManagerException;
+
+class ShareException extends PasswordManagerException {
+
+}

apps/PasswordManager/Factory/Api/Node/Share/PublicShareFactory.php

@@ -21,9 +21,10 @@
 
 namespace KSA\PasswordManager\Factory\Api\Node\Share;
 
-use KSA\PasswordManager\Api\Node\Share\PublicShare;
+use KSA\PasswordManager\Api\Node\Share\Public\PublicShare;
 use KSA\PasswordManager\Repository\Node\NodeRepository;
 use KSA\PasswordManager\Repository\PublicShareRepository;
+use KSA\PasswordManager\Service\AccessService;
 use KSA\PasswordManager\Service\Node\Share\ShareService;
 use KSP\Core\Service\HTTP\IResponseService;
 use Psr\Container\ContainerInterface;
@@ -38,6 +39,7 @@ public function __invoke(ContainerInterface $container): PublicShare {
             , $container->get(PublicShareRepository::class)
             , $container->get(LoggerInterface::class)
             , $container->get(IResponseService::class)
+            , $container->get(AccessService::class)
         );
     }
 

apps/PasswordManager/Factory/Api/Node/Share/PublicShareSingleFactory.php

@@ -21,7 +21,7 @@
 
 namespace KSA\PasswordManager\Factory\Api\Node\Share;
 
-use KSA\PasswordManager\Api\Node\Share\PublicShareSingle;
+use KSA\PasswordManager\Api\Node\Share\Public\PublicShareSingle;
 use KSA\PasswordManager\Repository\Node\NodeRepository;
 use KSA\PasswordManager\Repository\PublicShareRepository;
 use KSA\PasswordManager\Service\Node\Credential\CredentialService;

apps/PasswordManager/Factory/Api/Node/Share/RemoveFactory.php

@@ -21,7 +21,7 @@
 
 namespace KSA\PasswordManager\Factory\Api\Node\Share;
 
-use KSA\PasswordManager\Api\Node\Share\Remove;
+use KSA\PasswordManager\Api\Node\Share\Regular\Remove;
 use KSA\PasswordManager\Repository\Node\NodeRepository;
 use Psr\Container\ContainerInterface;
 
@@ -33,4 +33,4 @@ public function __invoke(ContainerInterface $container): Remove {
         );
     }
 
-}
+}

apps/PasswordManager/Factory/Api/Node/Share/ShareFactory.php

@@ -21,7 +21,7 @@
 
 namespace KSA\PasswordManager\Factory\Api\Node\Share;
 
-use KSA\PasswordManager\Api\Node\Share\Share;
+use KSA\PasswordManager\Api\Node\Share\Regular\Share;
 use KSA\PasswordManager\Repository\Node\NodeRepository;
 use KSA\PasswordManager\Service\Node\NodeService;
 use KSA\PasswordManager\Service\Node\Share\ShareService;

apps/PasswordManager/Factory/Api/Node/ShareableUsersFactory.php

@@ -21,7 +21,7 @@
 
 namespace KSA\PasswordManager\Factory\Api\Node;
 
-use KSA\PasswordManager\Api\Node\Share\ShareableUsers;
+use KSA\PasswordManager\Api\Node\Share\Regular\ShareableUsers;
 use KSA\PasswordManager\Repository\Node\NodeRepository;
 use KSP\Core\Repository\User\IUserRepository;
 use KSP\Core\Service\HTTP\IJWTService;
@@ -39,4 +39,4 @@ public function __invoke(ContainerInterface $container): ShareableUsers {
         );
     }
 
-}
+}

apps/PasswordManager/Repository/PublicShareRepository.php

@@ -27,6 +27,7 @@
 use KSA\PasswordManager\Entity\Node\Node;
 use KSA\PasswordManager\Entity\Share\NullShare;
 use KSA\PasswordManager\Entity\Share\PublicShare;
+use KSA\PasswordManager\Exception\Node\Share\ShareException;
 use KSA\PasswordManager\Exception\PasswordManagerException;
 use KSP\Core\Backend\IBackend;
 use KSP\Core\DTO\User\IUser;
@@ -115,6 +116,42 @@ public function getShare(string $hash): PublicShare {
 
     }
 
+    public function getShareById(int $id): PublicShare {
+        $queryBuilder = $this->backend->getConnection()->createQueryBuilder();
+        $queryBuilder->select(
+            [
+                's.id'
+                , 's.hash'
+                , 's.expire_ts'
+                , 's.node_id'
+            ]
+        )
+            ->from('pwm_public_share', 's')
+            ->where('s.`id` = ?')
+            ->setParameter(0, $id);
+
+        $result = $queryBuilder->executeQuery();
+        $rows   = $result->fetchAllNumeric();
+
+        if (0 === count($rows)) {
+            return new NullShare();
+        }
+
+        $row       = $rows[0];
+        $shareId   = $row[0];
+        $shareHash = $row[1];
+        $expireTs  = $row[2];
+        $nodeId    = $row[3];
+
+        return new PublicShare(
+            (int) $shareId,
+            (int) $nodeId,
+            (string) $shareHash,
+            $this->dateTimeService->fromFormat($expireTs)
+        );
+
+    }
+
     public function getShareByNode(Node $node): PublicShare {
         $queryBuilder = $this->backend->getConnection()->createQueryBuilder();
         $queryBuilder->select(
@@ -209,6 +246,20 @@ public function removeByUser(IUser $user): bool {
         }
     }
 
+    public function remove(PublicShare $share): PublicShare {
+        try {
+            $queryBuilder = $this->backend->getConnection()->createQueryBuilder();
+            $queryBuilder->delete('pwm_public_share', 'pps')
+                ->where('id = ?')
+                ->setParameter(0, $share->getId())
+                ->executeStatement();
+            return $share;
+        } catch (Exception $e) {
+            $this->logger->warning('can not remove users public share', ['share' => $share, 'exception' => $e]);
+            throw new ShareException();
+        }
+    }
+
     public function removeOutdated(): bool {
         $now = $this->dateTimeService->toYMDHIS(new DateTimeImmutable());
         try {

apps/PasswordManager/Test/Integration/Api/Node/Share/PublicShareSingleTest.php → apps/PasswordManager/Test/Integration/Api/Node/Share/Public/PublicShareSingleTest.php

@@ -19,9 +19,9 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-namespace Integration\Api\Node\Share;
+namespace Integration\Api\Node\Share\Public;
 
-use KSA\PasswordManager\Api\Node\Share\PublicShareSingle;
+use KSA\PasswordManager\Api\Node\Share\Public\PublicShareSingle;
 use KSA\PasswordManager\Entity\Share\PublicShare;
 use KSA\PasswordManager\Repository\PublicShareRepository;
 use KSA\PasswordManager\Service\Node\Credential\CredentialService;

apps/PasswordManager/Test/Integration/Api/Node/Share/PublicShareTest.php → apps/PasswordManager/Test/Integration/Api/Node/Share/Public/PublicShareTest.php

@@ -19,10 +19,10 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-namespace Integration\Api\Node\Share;
+namespace Integration\Api\Node\Share\Public;
 
 use DateTime;
-use KSA\PasswordManager\Api\Node\Share\PublicShare;
+use KSA\PasswordManager\Api\Node\Share\Public\PublicShare;
 use KSA\PasswordManager\ConfigProvider;
 use KSA\PasswordManager\Entity\IResponseCodes;
 use KSA\PasswordManager\Service\Node\Credential\CredentialService;

apps/PasswordManager/Test/Integration/Api/Node/Share/RemoveTest.php → apps/PasswordManager/Test/Integration/Api/Node/Share/Regular/RemoveTest.php

@@ -19,9 +19,9 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-namespace Integration\Api\Node\Share;
+namespace Integration\Api\Node\Share\Regular;
 
-use KSA\PasswordManager\Api\Node\Share\Remove;
+use KSA\PasswordManager\Api\Node\Share\Regular\Remove;
 use KSA\PasswordManager\Repository\PublicShareRepository;
 use KSA\PasswordManager\Service\Node\Share\ShareService;
 use KSA\PasswordManager\Test\Integration\TestCase;

apps/PasswordManager/Test/Integration/Api/Node/Share/ShareTest.php → apps/PasswordManager/Test/Integration/Api/Node/Share/Regular/ShareTest.php

@@ -19,9 +19,9 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-namespace Integration\Api\Node\Share;
+namespace Integration\Api\Node\Share\Regular;
 
-use KSA\PasswordManager\Api\Node\Share\Share;
+use KSA\PasswordManager\Api\Node\Share\Regular\Share;
 use KSA\PasswordManager\Test\Integration\TestCase;
 use Ramsey\Uuid\Uuid;
 

apps/PasswordManager/Test/Integration/Api/Node/ShareableUsersTest.php → apps/PasswordManager/Test/Integration/Api/Node/Share/Regular/ShareableUsersTest.php

@@ -19,9 +19,9 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-namespace KSA\PasswordManager\Test\Integration\Api\Node;
+namespace Integration\Api\Node\Share\Regular;
 
-use KSA\PasswordManager\Api\Node\Share\ShareableUsers;
+use KSA\PasswordManager\Api\Node\Share\Regular\ShareableUsers;
 use KSA\PasswordManager\Entity\Node\Credential\Credential;
 use KSA\PasswordManager\Repository\Node\NodeRepository;
 use KSA\PasswordManager\Test\Integration\TestCase;
@@ -44,4 +44,4 @@ public function testShareableUsers(): void {
         $this->assertTrue(true === $this->getResponseService()->isValidResponse($response));
     }
 
-}
+}

apps/PasswordManager/config/api_router.php

@@ -41,11 +41,11 @@
 use KSA\PasswordManager\Api\Node\Pwned\ChartData;
 use KSA\PasswordManager\Api\Node\Pwned\IsActive;
 use KSA\PasswordManager\Api\Node\Search;
-use KSA\PasswordManager\Api\Node\Share\PublicShare;
-use KSA\PasswordManager\Api\Node\Share\PublicShareSingle;
-use KSA\PasswordManager\Api\Node\Share\Remove as RemoveShare;
-use KSA\PasswordManager\Api\Node\Share\Share;
-use KSA\PasswordManager\Api\Node\Share\ShareableUsers;
+use KSA\PasswordManager\Api\Node\Share\Public\PublicShare;
+use KSA\PasswordManager\Api\Node\Share\Public\PublicShareSingle;
+use KSA\PasswordManager\Api\Node\Share\Regular\Remove as RemoveShare;
+use KSA\PasswordManager\Api\Node\Share\Regular\Share;
+use KSA\PasswordManager\Api\Node\Share\Regular\ShareableUsers;
 use KSA\PasswordManager\ConfigProvider;
 use KSA\PasswordManager\Middleware\NodeAccessMiddleware;
 use KSP\Api\IRoute;
@@ -95,6 +95,12 @@
             , IRoute::METHOD     => IVerb::POST
             , IRoute::NAME       => PublicShare::class
         ],
+        [
+            IRoute::PATH         => ConfigProvider::PASSWORD_MANAGER_PUBLIC_SHARE_PUBLIC
+            , IRoute::MIDDLEWARE => [NodeAccessMiddleware::class, PublicShare::class]
+            , IRoute::METHOD     => IVerb::DELETE
+            , IRoute::NAME       => PublicShare::class . '@' . IVerb::DELETE
+        ],
         [
             IRoute::PATH         => ConfigProvider::PASSWORD_MANAGER_PUBLIC_SHARE_REMOVE
             , IRoute::MIDDLEWARE => [NodeAccessMiddleware::class, RemoveShare::class]