Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use DESTDIR in Makefile #31

Merged
merged 1 commit into from
Aug 11, 2016
Merged

Use DESTDIR in Makefile #31

merged 1 commit into from
Aug 11, 2016

Conversation

Shir0kamii
Copy link
Contributor

Hi,

I would like to package git-fixup for the gentoo distribution since I found it useful and would like to share it with my fellow workers (we are a few to be on gentoo).

The problem is, I discovered that the Makefile of your project doesn't use the $DESTDIR variable to allow installation to another place, which is almost mandatory on gentoo.

I hope it won't bother you to add them!

Cheers

@keis
Copy link
Owner

keis commented Aug 11, 2016

Thanks @Shir0kamii

It's a common convention I think so I see no issue supporting it :)

@keis keis merged commit 229a173 into keis:master Aug 11, 2016
@keis
Copy link
Owner

keis commented Aug 11, 2016

Tagged version v1.1.1 that includes this fix. If you have an overlay or other installations instructions I would be happy to include that in the readme.

@Shir0kamii
Copy link
Contributor Author

Thank you for the offer! I indeed have an overlay, available at https://github.com/Shir0kamii/shiro-overlay.

@keis
Copy link
Owner

keis commented Aug 13, 2016

I've been away from gentoo for a while, is layman still the preferred tool to add overlays?

@Shir0kamii
Copy link
Contributor Author

I thought it was deprecated but it seems it's still the best way to do it.

Anyway, you can point to https://wiki.gentoo.org/wiki/Overlay since it contains all the needed informations about overlays and would be updated if changes were to happen.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants