Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove filenames in tab-completion in fish >= 3.5 #63

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Remove filenames in tab-completion in fish >= 3.5 #63

merged 1 commit into from
Aug 29, 2022

Conversation

pe
Copy link
Contributor

@pe pe commented Aug 27, 2022

Fish 3.5 did speed up loading custom fish completions. But also changed its behaviour in fish-shell/fish-shell@ff72e3f. It is now necessary to define at least one custom completion for 'git-fixup'. That pointed to an easier way: Write completions for 'git-fixup' and fish will forward them from 'git fixup' fish-shell/fish-shell@0916176

Fish 3.5 did speed up loading custom fish completions. But also changed its behaviour in fish-shell/fish-shell@ff72e3f. It is now necessary to define at least one custom completion for 'git-fixup'. That pointed to an easier way: Write completions for 'git-fixup' and fish will forward them from 'git fixup' fish-shell/fish-shell@0916176
@keis
Copy link
Owner

keis commented Aug 28, 2022

Hey, thanks for the pull request!

Do you know if this script will work on earlier version of fish too? Or is it relying on some new features?

@pe
Copy link
Contributor Author

pe commented Aug 28, 2022

I did not test it. But it should work with fish >= 3.2 released in March 2021. All Linux distributions I checked have fish >= 3.3.

People using older version of fish would only get completions for git-fixup but not git fixup.

@keis keis merged commit 01e431b into keis:master Aug 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants