Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add --all option #66

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Add --all option #66

merged 1 commit into from
Sep 30, 2023

Conversation

jreybert
Copy link

This new option allows to display all the commits in the range base..HEAD.

This option does not use all the smart closest commit search in the range. But it allows to use the interactive selection. It is usefull when the user does a modification unrelated to the target commit, and knows which commit it is. In that, it may do:

  • git commit -m "fixfix"
  • git rebase -i base

This new option saves one command, and is shorted to:

  • git fixup -a -b base

@keis keis self-assigned this Jul 21, 2023
Copy link
Owner

@keis keis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

The feature sounds pretty reasonable but I have few comments on how it's implemented.

git-fixup Outdated Show resolved Hide resolved
git-fixup Outdated Show resolved Hide resolved
@jreybert
Copy link
Author

At least I made the suggestions.

I accidentally closed the current MR, I am trying to reopen it.

@jreybert jreybert reopened this Sep 30, 2023
This new option allows to display all the commits in the range
base..HEAD.

This option does not use all the smart closest commit search in the
range. But it allows to use the interactive selection.
It is usefull when the user does a modification unrelated to the target
commit, and knows which commit it is. In that, it may do:
* git commit -m "fixfix"
* git rebase -i base

This new option saves one command, and is shorted to:
* git fixup -A -b base
@keis
Copy link
Owner

keis commented Sep 30, 2023

I changed the short flag to -A to not clash with the recently added --amend option. I don't love it but it's at least consistent with the -A/--all of git add

@keis keis merged commit f964653 into keis:master Sep 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants