fix: missing type check on `sortScripts` #139

fisker · 2020-01-10T07:38:09Z

require('sort-package-json')({scripts: undefined})
Thrown:
TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at sortScripts (<cwd>\node_modules\sort-package-json\index.js:117:24)

keithamus · 2020-01-10T11:14:44Z

🎉 This PR is included in version 1.38.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

fisker added 2 commits January 10, 2020 15:36

fix: missing type check on sortScripts

716f0c0

perf: skip type check inside sortScripts

bfa7ecf

keithamus approved these changes Jan 10, 2020

View reviewed changes

keithamus merged commit 869178f into keithamus:master Jan 10, 2020

keithamus added the released label Jan 10, 2020

fisker deleted the fix-sort-script branch January 10, 2020 23:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: missing type check on `sortScripts` #139

fix: missing type check on `sortScripts` #139

fisker commented Jan 10, 2020 •

edited

Loading

keithamus commented Jan 10, 2020

fix: missing type check on sortScripts #139

fix: missing type check on sortScripts #139

Conversation

fisker commented Jan 10, 2020 • edited Loading

keithamus commented Jan 10, 2020

fix: missing type check on `sortScripts` #139

fix: missing type check on `sortScripts` #139

fisker commented Jan 10, 2020 •

edited

Loading