Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

export shellEscape #26

Merged
merged 1 commit into from
Jun 16, 2018
Merged

export shellEscape #26

merged 1 commit into from
Jun 16, 2018

Conversation

wmertens
Copy link
Contributor

Rationale:

  • it is very useful for writing commands from scripts
  • nps-utils already imports it
  • no need to import as well, no need to add to package dependencies

@codecov
Copy link

codecov bot commented Jun 16, 2018

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          79     79           
=====================================
  Hits           79     79
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1794fa5...81b78dd. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍

@kentcdodds kentcdodds merged commit e4acb58 into kentcdodds:master Jun 16, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants