Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix build + make screenshot open over where it was created #24

Merged
merged 17 commits into from
May 26, 2022

Conversation

ayroblu
Copy link
Contributor

@ayroblu ayroblu commented Mar 2, 2022

Hey, I love your project, I made a couple changes that I prefer, I can take them back if you don't like them, but basically adds:

  1. Fix build -> use LoginServiceKit 2.3.0
  2. Add github actions build (you'll need to add your certs etc to make this work) (makefile, ExportOptions etc are related)
  3. Double tap to close screenshot
  4. Disable click opacity because of 3.
  5. Make screenshot over where it was created by parsing the screencapture tool stderr

@kentya6 kentya6 changed the base branch from master to v1.0.0 May 26, 2022 13:46
@kentya6
Copy link
Owner

kentya6 commented May 26, 2022

@ayroblu
Sorry for the late reply.
I will be released v1.0.0 soon, and include this changes there.
Thank you for your contribution!

@kentya6 kentya6 merged commit 4d36cd0 into kentya6:v1.0.0 May 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants