Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

when focusOnChange is false -> remove attr tabindex #3109

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

alexandrubotez
Copy link
Contributor

When tabbing through the slides, they have tabindex 0 even though focusOnChange is false.
The issue appears from initADA function where the slides that are in view are given the value 0 for tabidex.

I have added an if for the verification of the focusOnChange option.

screenshot here

     if (_.options.focusOnChange) {
           _.$slides.eq(i).attr({'tabindex': '0'});
         } else {
           _.$slides.eq(i).removeAttr('tabindex');
         }

I believe this is the only thing that is missing from #3032

Issue here.

@leggomuhgreggo
Copy link
Collaborator

Nice, thanks!

@leggomuhgreggo leggomuhgreggo merged commit dcdc97c into kenwheeler:master Sep 15, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants