-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add RBAC Guidelines #2
Conversation
Thanks for the PR! |
The currently used |
README.md
Outdated
* Prefer namespaced Roles and Rolebindings over ClusterRoles and ClusterRoleBindings | ||
|
||
### Example: | ||
Let's image, the service (deployment) `keptn-sample-service` needs read access for the secret "keptn-sample-secret". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to clarify this sentence, e.g.,:
Let's imagine the Keptn service (which corresponds to a Kubernetes deployment and service) named keptn-sample-service
requires read-access for a secret called keptn-sample-secret
in the keptn
namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add the changes that are necessary if no additional permissions are needed.
It would be helpful to have two scenarios:
Scenario 1: no additional permissions required --> what to change
Scenario 2: permissions to read a secret required --> what to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.