Skip to content

Misc #957

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2025
Merged

Misc #957

merged 3 commits into from
Feb 24, 2025

Conversation

troglobit
Copy link
Contributor

@troglobit troglobit commented Feb 23, 2025 •
edited
Loading

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@troglobit
Fix #956: skip chown() on running-config, not applicable
6a5bf66 
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit
Fix #923: drop default route for IPv4 autoconf
f690cd2 
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit added the ci:main Build default defconfig, not minimal label Feb 23, 2025
@troglobit troglobit added this to the Infix v25.02 milestone Feb 23, 2025
@troglobit troglobit requested a review from rical February 23, 2025 15:23
@troglobit troglobit self-assigned this Feb 23, 2025
@troglobit troglobit requested a review from jovatn February 23, 2025 15:29
@troglobit
Copy link
Contributor Author

Starting with a DRAFT PR to test the waters on this one. Two very basic fixes that I've reset 25.02 target on now that they're fixed. I foresee no downsides to merge.

Will do a follow-up push with updated ChangeLog as soon as the tests pass on this first push.

@troglobit
doc: update ChangeLog for v25.02
2d7dedf 
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit marked this pull request as ready for review February 24, 2025 04:42
rical
rical approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@rical rical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jovatn
jovatn approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@jovatn jovatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I tested the behavior when configuring IPv4 autoconf on an interface, and no implicit default route is added now.
As a bonus, I think we had another bug related to the implicit default route (it seems the route lingered when autoconf is disabled), which no longer applies/exists. :-)

@troglobit troglobit merged commit 638862d into main Feb 24, 2025
6 checks passed
@troglobit troglobit deleted the misc branch February 24, 2025 08:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rical rical rical approved these changes

@jovatn jovatn jovatn approved these changes

Assignees

@troglobit troglobit

Labels
ci:main Build default defconfig, not minimal
Projects
None yet
Milestone
Infix v25.02
Development

Successfully merging this pull request may close these issues.

Weird error while copy factory-config running-config Skip implicit default route for IPv4 autoconf
3 participants
@troglobit @rical @jovatn