Add new option 'showCommandButtons' #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new option to hide the clear, preview and save buttons from the controls.
|
This is a great PR, everything is where is should be and no linting errors, excellent work @srachner . My only 2 questions are if Also maybe Seriously, fantastic PR. |
* Renamed 'showCommandButtons' option to 'showActionButtons'. * Changed exported action and helper name from 'showXML' to 'showData'.
| @@ -1510,6 +1519,7 @@ function formBuilderEventsFn() { | |||
| }, | |||
| sortableControls: false, | |||
| stickyControls: false, | |||
| showActionButtons: true, | |||
|
Thank you! You're right about the naming, I've changed it according to your suggestions . |
kevinchappell
pushed a commit
that referenced
this pull request
Sep 12, 2016
* Add 'showCommandButtons' option. Adds a new option to hide the clear, preview and save buttons from the controls. * Add helper for the showXML data dialog and export it as an action. * Rename newly added option and helper method. * Renamed 'showCommandButtons' option to 'showActionButtons'. * Changed exported action and helper name from 'showXML' to 'showData'.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new option which allows deactivating the clear, preview and save buttons in the controls. I need this for a project which already has separate controls for some actions. I also made the preview dialog action accessible, so that all three commands can be triggered from an external script.