Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

upgraded fineuploader plugin to use cdnjs by default so it no longer … #509

Merged
merged 2 commits into from
May 30, 2017

Conversation

brentkelly
Copy link
Contributor

…requires installation, make template configurable

Thanks @rnicholus for pointing out the CDN.

@kevinchappell - one thing you may want to consider now that it doesn't require installation & 'just works', is if it is worth including this in the core set of controls - either as the default file uploader control, or possibly in the subtype dropdown for file uploader.

Alternatively can just leave it as a plugin - which would make sense if a lot of the users wouldn't use this functionality.

Guess it depends how lightweight you are trying to keep the project out of the box.

…requires installation, make template configurable
@kevinchappell
Copy link
Owner

@brentkelly I definitely think its worth it and should exist as a subtype. If a dev wants it to be the default they can either use combination of disableFields and fields option or the replaceType option I am proposing in #510

@brentkelly
Copy link
Contributor Author

OK cool - I'll rework this PR & let you know when it's good to go.

…f file. Make `type`:`file` support `subtype`
@kevinchappell kevinchappell merged commit 3e26bee into kevinchappell:master May 30, 2017
@brentkelly brentkelly deleted the feature/fineuploader branch May 30, 2017 14:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants