Fineuploader error handling & reporting #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int returns an error (e.g. extension errors, too large etc etc)
…ty. updated fineuploader to use this instead of inlining it in the HTML template - bit cleaner this way.
… what files were uploaded required javascript. This commit makes it work similar to the RTE controls which keep a hidden input synced with the desired output - in this case a list of the filenames uploaded to the server
|
@kevinchappell - I added another commit to this PR. As I've started to use this in a project, I noticed it was missing some important features. This latest one is it wasn't actually outputting the names of the files uploaded to a hidden input or anything like that. So to get them, you had to interact with the fineuploader object over javascript etc. Doesn't really fit the pattern of other rich components like the RTE controls which work transparently with a form post using a hidden input. So I've upgraded this to do the same in 6660c20 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fineuploader silently fails by default when your server endpoint returns an error (wrong file type, too large, unwriteable upload dir etc). This PR adds support for displaying those errors in a user friendly way within the control.
To support this I also upgraded controls to be able to define css rules with the
this.cssarray (so it now supports both externally linked CSS, as well as inline css rules).Tested in chrome, edge, and firefox.
There were also a couple of other more obscure bugs in fineuploader that are fixed in this PR.
My formbuilder demo won't compile in IE so couldn't test there, but it's pretty standard jQuery so can't see why it wouldn't work (then again ... we are talking about IE!)