Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug: Non-mkv Files specified as arguments that get remuxed don't get filtered #16

Open
WhitePeter opened this issue Apr 19, 2024 · 1 comment
Assignees
Labels

Comments

@WhitePeter
Copy link
Collaborator

I just found out that non-mkv files that are passed as arguments will not have the resulting remuxed file filtered/tagged. The reason is that the find command only uses the argument list $@ as starting points, and because the corresponding mkv-file is not in that list it will get passed over.

WhitePeter added a commit that referenced this issue Apr 19, 2024
New function tag_tracks() gets called right after successful remux.

Fixes #16
@WhitePeter
Copy link
Collaborator Author

For now, the fix is in the less_bash branch but it shouldn't be too hard to do similarly on master, I am just not in the mood right now. ;-)

BTW, that new function is basically all that needs to remain of the functionality, IMHO. Only take a list of files, or maybe even just one, as argument(s) and do away with the "recursive" mode, as suggested in PR #12. Maybe remuxing can stay, but I don't really see the point. mkvrg is in the tagging business and should stay in its lane. ;-) Do one thing.

@WhitePeter WhitePeter self-assigned this Apr 19, 2024
@WhitePeter WhitePeter added the bug label Apr 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant