-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Mapping colors to categories (proof-of-concept) #591
base: legacy
Are you sure you want to change the base?
Conversation
Glad you are looking in to this! Ideally, we can find a way for Thunderbird to provide ephemeral categories, that don't show up globally but are available on a per-provider basis. In lieu of that, having an opt-in setting in the provider to include these colors sounds reasonable to me. The userChrome.css changes, while they are a nice improvement, I don't think should be part of the provider. If you feel this is an improvement not just for the Provider, you can file a bug with the changes in core, I believe here: https://searchfox.org/comm-central/source/calendar/base/themes/common/calendar-views.css You should be able to clear the categories on uninstall, see here: https://github.com/kewisch/gdata-provider/blob/legacy/src/api/gdata.js#L62 which is called on uninstall. It might make sense to place it into the UI unregister here: https://github.com/kewisch/gdata-provider/blob/legacy/src/legacy/modules/gdataUI.jsm#L69 |
Thank you for the response! One further question: Does it make sense to implement this feature in the |
I am struggling with two issues right now, which may come down to my lack of experience with developing Thunderbird addons.
Any input would be appreciated. |
You can use ChromeUtils.import() to import a jsm file. If you want to execute things on a calendar, I'd recommend getting calendars through the calendar manager.
You can use |
Thank you for your input!
While that did not work in
After some attempts I had success with As far as I am concerned, this pull request is feature complete, though it needs a thorough review and more testing. Is there anything else you would like to see? |
- clarification on the settings page - still missing: Listener for change of addon preferences
f700be3
to
7658166
Compare
The single biggest issue I had with Google Calendar and Thunderbird was the lack of support for event colors. In this proof-of-concept I approach this issue the following way:
This allows users on Thunderbird to both see and change the colors of events.
Future
If you are interested in integrating this code, please tell me which features you would like to see. Some ideas of mine:
This feature should be opt-in so users don't get 11 new categories they don't want.
I don't think the new categories can be automatically removed when the addon is uninstalled. This feature is not strictly necessary in my eyes, but if you have any ideas how to do that I'd love to hear them.
I have written a
userChrome.css
to make the color box more apparent and get the layout to be more in line with Google, which could become another opt-in feature:Click to expand css code