Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RecoParticleVertexAssociation: rename relation members for consistency between association #134

Closed
wants to merge 3 commits into from
Closed

RecoParticleVertexAssociation: rename relation members for consistency between association #134

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
652a9a4
rename for consistency between association
fdplacido Dec 15, 2021
c8dc545
change association variable names to 'from' and 'to'
fdplacido Mar 14, 2022
e6a6978
Merge branch 'master' into rename_association
vvolkl May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions edm4hep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,68 +416,68 @@ datatypes :
Members:
- float weight // weight of this association
OneToOneRelations :
- edm4hep::ReconstructedParticle rec // reference to the reconstructed particle
- edm4hep::MCParticle sim // reference to the Monte-Carlo particle
- edm4hep::ReconstructedParticle from // reference to the reconstructed particle
- edm4hep::MCParticle to // reference to the Monte-Carlo particle

edm4hep::MCRecoCaloAssociation:
Description: "Association between a CaloHit and the corresponding simulated CaloHit"
Author: "C. Bernet, B. Hegner"
Members:
- float weight // weight of this association
OneToOneRelations:
- edm4hep::CalorimeterHit rec // reference to the reconstructed hit
- edm4hep::SimCalorimeterHit sim // reference to the simulated hit
- edm4hep::CalorimeterHit from // reference to the reconstructed hit
- edm4hep::SimCalorimeterHit to // reference to the simulated hit
Comment on lines +431 to +432
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- edm4hep::CalorimeterHit from // reference to the reconstructed hit
- edm4hep::SimCalorimeterHit to // reference to the simulated hit
- edm4hep::CalorimeterHit to // reference to the reconstructed hit
- edm4hep::SimCalorimeterHit from // reference to the simulated hit

The name of the datatype suggests that the MC part is first, so I think it is more intuitive for it to be the "from" part of the association, right? A similar argument can be made for some of the other associations as well.


edm4hep::MCRecoTrackerAssociation:
Description: "Association between a TrackerHit and the corresponding simulated TrackerHit"
Author : "C. Bernet, B. Hegner"
Members:
- float weight // weight of this association
OneToOneRelations:
- edm4hep::TrackerHit rec // reference to the reconstructed hit
- edm4hep::SimTrackerHit sim // reference to the simulated hit
- edm4hep::TrackerHit from // reference to the reconstructed hit
- edm4hep::SimTrackerHit to // reference to the simulated hit

edm4hep::MCRecoTrackerHitPlaneAssociation:
Description: "Association between a TrackerHitPlane and the corresponding simulated TrackerHit"
Author : "Placido Fernandez Declara"
Members:
- float weight // weight of this association
- float weight // weight of this association
OneToOneRelations:
- edm4hep::TrackerHitPlane rec // reference to the reconstructed hit
- edm4hep::SimTrackerHit sim // reference to the simulated hit
- edm4hep::TrackerHitPlane from // reference to the reconstructed hit
- edm4hep::SimTrackerHit to // reference to the simulated hit

edm4hep::MCRecoCaloParticleAssociation:
Description: "Association between a CalorimeterHit and a MCParticle"
Author : "Placido Fernandez Declara"
Members:
- float weight // weight of this association
- float weight // weight of this association
OneToOneRelations:
- edm4hep::CalorimeterHit rec // reference to the reconstructed hit
- edm4hep::MCParticle sim // reference to the Monte-Carlo particle
- edm4hep::CalorimeterHit from // reference to the reconstructed hit
- edm4hep::MCParticle to // reference to the Monte-Carlo particle

edm4hep::MCRecoClusterParticleAssociation:
Description: "Association between a Cluster and a MCParticle"
Author : "Placido Fernandez Declara"
Members:
- float weight // weight of this association
- float weight // weight of this association
OneToOneRelations:
- edm4hep::Cluster rec // reference to the cluster
- edm4hep::MCParticle sim // reference to the Monte-Carlo particle
- edm4hep::Cluster from // reference to the cluster
- edm4hep::MCParticle to // reference to the Monte-Carlo particle

edm4hep::MCRecoTrackParticleAssociation:
Description: "Association between a Track and a MCParticle"
Author : "Placido Fernandez Declara"
Members:
- float weight // weight of this association
- float weight // weight of this association
OneToOneRelations:
- edm4hep::Track rec // reference to the track
- edm4hep::MCParticle sim // reference to the Monte-Carlo particle
- edm4hep::Track from // reference to the track
- edm4hep::MCParticle to // reference to the Monte-Carlo particle

edm4hep::RecoParticleVertexAssociation:
Description: "Association between a Reconstructed Particle and a Vertex"
Author : "Placido Fernandez Declara"
Members:
- float weight // weight of this association
- float weight // weight of this association
OneToOneRelations:
- edm4hep::ReconstructedParticle rec // reference to the reconstructed particle
- edm4hep::Vertex vertex // reference to the vertex
- edm4hep::ReconstructedParticle from // reference to the reconstructed particle
- edm4hep::Vertex to // reference to the vertex