Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Skip the full file check if the rntuple file has not been produced #369

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Skip the check for the full file in case the RNTuple has not been produce (e.g. if podio hasn't been built with RNTuple support)

ENDRELEASENOTES

This is a slightly hackish solution that leverages pytests capabilities to skip tests rather than failing them. Unfortunately it returns a non-zero exit code in that case, so we need the SKIP_REGULAR_EXPRESSION (which we can now make a bit more narrow). This works around the same issue as AIDASoft/podio#677 but entirely within EDM4hep.

I tried first with cmake features, but neither REQUIRED_FILES nor FIXTURES_REQUIRED can be made to work at the moment, as both of them mark the test suite as failed if they are used to not run a test. See these discussions: first second

@tmadlener tmadlener merged commit 76ae71f into key4hep:main Sep 17, 2024
7 of 10 checks passed
@tmadlener tmadlener deleted the skip-rntuple-tests branch September 17, 2024 11:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant