Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add the possibility to set edm4hep::utils::ParticleIDMeta via the IMetadataSvc #273

Merged
merged 15 commits into from
Jan 29, 2025

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Dec 20, 2024

BEGINRELEASENOTES

  • Make it possible to use edm4hep::utils::ParticleIDMeta with the MetadataSvc
    • Add template specializations for get and put that defer to the corresponding utility calls in EDM4hep
    • Add tests to ensure that metadata is indeed usable this way with the utilities in EDM4hep

ENDRELEASENOTES

This would be option 1 sketched out in #272

@tmadlener
Copy link
Contributor Author

tmadlener commented Jan 16, 2025

I have added a "small" test case that runs similar checks as in the functional algorithm as a standalone application (effectively hard-coding the expected parameter and algorithm names). I have done it in c++ because the PIDHandler is not yet really usable in python (see key4hep/EDM4hep#396).

Once the nightly builds have picked up key4hep/EDM4hep#395, CI should also start to pass again (tomorrow).

@tmadlener tmadlener changed the title [WIP] Add the possibility to set edm4hep::utils::ParticleIDMeta via the IMetadataSvc Add the possibility to set edm4hep::utils::ParticleIDMeta via the IMetadataSvc Jan 16, 2025
Necessary because there is a new output collection in the functional
producer that is used in several places
@tmadlener
Copy link
Contributor Author

Since I touched the ExampleFunctionalProducerMultiple to also create ReconstructedParticles, I had to fix a few other tests to also make them pass. The alternative would be to introduce a dedicated producer for the ParticleID metadata tests. I am not sure if it's worth it, but it can obviously be done.

Technically already covered via Gaudi, but this makes it explicit
@jmcarcell
Copy link
Member

I'll give this another look and update key4hep/k4MarlinWrapper#216 to use this to see if anything is missing between today and tomorrow.

Copy link
Member

@jmcarcell jmcarcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good related to key4hep/k4MarlinWrapper#216

CMakeLists.txt Show resolved Hide resolved
tmadlener and others added 3 commits January 24, 2025 17:25
@jmcarcell
Copy link
Member

Merge?

As a note once we stop using Ubuntu 22.04 (because there are already builds for Ubuntu 24.04, key4hep/key4hep-spack#700) we can use <format>; anyway Gaudi doesn't support GCC 11 anymore...

@tmadlener
Copy link
Contributor Author

Merge?

Yes, this is done from my point of view, unless someone still has comments.

@jmcarcell jmcarcell merged commit 76ba468 into main Jan 29, 2025
7 of 9 checks passed
@jmcarcell jmcarcell deleted the add-pid-metadata branch January 29, 2025 08:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants