Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat:(roles): Importable role by rolename #1043

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

denniskniep
Copy link
Contributor

No description provided.

Signed-off-by: Dennis Kniep <kniepdennis@gmail.com>
Copy link
Contributor

@sschu sschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denniskniep I am not sure about adding this dependency to a BSD-licensed library. Is this really necessary or can we work around this?

@sschu sschu self-requested a review December 31, 2024 09:09
@denniskniep
Copy link
Contributor Author

@sschu thanks for the review, but the dependency is not new. It is already used by resource_keycloak_openid_client.go for the same purpose: Handle import: true (see here)

Copy link
Contributor

@sschu sschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Ok, then I guess this is fine.

@sschu sschu merged commit de36bd6 into keycloak:main Dec 31, 2024
10 checks passed
@kherock
Copy link
Contributor

kherock commented Jan 3, 2025

After testing this provider against my stack, my plans are showing hundreds of replacements every roles caused by this new attribute:

  # keycloak_role.admin_console_administrator must be replaced
-/+ resource "keycloak_role" "admin_console_administrator" {
      ~ attributes      = {} -> (known after apply)
      + composite_roles = (known after apply)
      ~ id              = "3af3eb01-7c22-4d30-89e3-77194f4dc445" -> (known after apply)
      + import          = false # forces replacement
        name            = "administrator"
        # (3 unchanged attributes hidden)
    }

Is this expected?

angeloxx pushed a commit to angeloxx/terraform-provider-keycloak that referenced this pull request Jan 26, 2025
Signed-off-by: Dennis Kniep <kniepdennis@gmail.com>
Signed-off-by: angeloxx <angeloxx@angeloxx.it>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants