Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove sidekiq-unique-jobs #851

Merged
merged 1 commit into from
May 27, 2024
Merged

Remove sidekiq-unique-jobs #851

merged 1 commit into from
May 27, 2024

Conversation

ezekg
Copy link
Member

@ezekg ezekg commented May 27, 2024

Related to #798. This gem has been causing outages lately as we scale. Right now, I'm still seeing slow Lua scripts when deleting items from large sets, e.g. when a spike of requests come in and jobs are queued up for each request, or when a lot of scheduled jobs are pushed to the queue. I tried to fix this upstream, but there's more issues and I don't have time to debug.

Follow up to fc1b739 (i.e. the fix for the big outage), which removed all mission-critical use of the gem. If and when we need job uniqueness, we can reach for Sidekiq Ent, which has timing guarantees.

@ezekg ezekg marked this pull request as ready for review May 27, 2024 16:48
@ezekg ezekg merged commit 8f2dc2d into master May 27, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant