Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add an id for Docker containers #3
Add an id for Docker containers #3
Changes from 1 commit
14e376b
7b12ce3
53a5807
5ffae30
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give me more detail on what
/proc/self/mountinfo
is and how it can be used as a unique ID? I don't thinkmountinfo
is Docker-specific.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ezekg , this idea of using
mountinfo
, came from this post: https://stackoverflow.com/a/71823877/3780957This post mentions, some versions do not have the ID at
/proc/self/cgroup
.I am not sure if this is Docker specific. I can confirm that I check on a Docker instance, and that file has the same ID as
/proc/self/cgroup
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got more info here. I think this is fine as long as you add a similar
if 'docker' in mountinfo
check as above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also more discussion with the above workarounds is at opencontainers/runtime-spec#1105.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question, if
__read__('/proc/self/mountinfo')
returnsNone
(because the file does not exist).Will
if 'docker' in mountinfo:
return an exception?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You’re right. I was only supplying pseudo code. I guess we should also check
if mountinfo and 'docker' in mountinfo:
. We shouldn’t raise an exception.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to fix the indentation (you're using 4 spaces but the rest of the file uses 2 spaces).
Please make sure the code runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no additional exception.
Currently on a Docker container the
if 'docker' in cgroup:
does not finddocker
, the endingException
works as intended. Same test withmountinfo
.When the full code does not find an ID raises the following: