Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade design system #9253

Merged
merged 137 commits into from
Feb 3, 2025
Merged

Upgrade design system #9253

merged 137 commits into from
Feb 3, 2025

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Aug 5, 2024

This pull request introduces multiple breaking changes and improvements across Keystone’s core packages. The primary focus of the pull request is the transition to @keystar/ui by removing @keystone-ui/*.

A number of seemingly unrelated breaking changes are included to reduce the burden of back-porting functionality that will then be removed soon thereafter. A few notable out-of-band changes include now supporting null defaults in numeric fields, and moving EndSession to only exist as part of @keystone-6/auth.

@gautamsi

This comment was marked as outdated.

@dcousens dcousens self-assigned this Aug 5, 2024
@kennedybaird

This comment was marked as outdated.

@dcousens
Copy link
Member Author

@kennedybaird I think adding a checkbox (or cookie, or) that can easily switch between different field modes will be incredibly helpful in debugging UX

@kennedybaird
Copy link
Contributor

@kennedybaird I think adding a checkbox (or cookie, or) that can easily switch between different field modes will be incredibly helpful in debugging UX

@dcousens - to clarify, you'd like this to expand the current tests/sandbox, or a new project in tests/test-projects?

@dcousens
Copy link
Member Author

tests/sandbox, but I think we can defer to @jossmac to know if that is useful in this pull request, or separately

@dcousens

This comment was marked as resolved.

@gautamsi
Copy link
Member

@jossmac I am sure you have noticed my work in #9186
We should move in the direction of SSR friendly design so that any SSR only rendering with NextJs 15 and react 19 should not require major rework in this regards.
They are around the corner and my idea is to move towards App router with maximizing SSR use in admin ui.

@dcousens dcousens force-pushed the introduce-keystar-ui branch 3 times, most recently from 96049f6 to f4d16cc Compare August 20, 2024 05:36
@keystonejs keystonejs deleted a comment from codesandbox-ci bot Aug 20, 2024
@dcousens dcousens force-pushed the introduce-keystar-ui branch 4 times, most recently from b7d26a3 to 1368261 Compare August 20, 2024 12:29
@kennedybaird
Copy link
Contributor

tests/sandbox, but I think we can defer to @jossmac to know if that is useful in this pull request, or separately

@jossmac, I'm going to start on this in another branch.

Also, wanted to point you towards #8402 if you haven't seen it - maybe you can factor that into this PR?

@dcousens dcousens force-pushed the introduce-keystar-ui branch from 2552031 to c527910 Compare August 21, 2024 07:31
@jossmac

This comment was marked as resolved.

@gautamsi
Copy link
Member

@jossmac @dcousens Is there any timeline on completion on this?

@dcousens
Copy link
Member Author

dcousens commented Sep 23, 2024

@gautamsi I think a significant amount of time is needed for QA and documenting or resolving any regressions, maybe the next step is an alpha RC

@gautamsi
Copy link
Member

lets plan to do alpha release soon along with #9186 and kill two birds with one stone. I can prepare my branch with changes from de#date.

@jossmac
Copy link
Member

jossmac commented Sep 27, 2024

For context @gautamsi, I had a few weeks between client projects which I was able to dedicate to this refactor but that's come to an end. I should hopefully find time here and there for bug fixes etc. however it will be far less focused.

@gautamsi
Copy link
Member

@jossmac It is going to be difficult to keep waiting for the community. It seems there is no intention to add major changes to the project, it would be good to open this up for community for governance.

I know as a company Thinkmill may have other priority and even new Keystatic but there are so much to work on here.

I have already started using my own release on npm, it would be good to have direction on this repo to make informed decision.

@dcousens
Copy link
Member Author

dcousens commented Sep 27, 2024

@gautamsi #9186 and this going out together, and soon, an an alpha sounds good to me; let's try for next week

@gautamsi

This comment was marked as resolved.

@dcousens dcousens force-pushed the introduce-keystar-ui branch from 3f9b938 to 1a0a342 Compare February 3, 2025 01:22
@dcousens dcousens force-pushed the introduce-keystar-ui branch from 1a0a342 to 8d2a469 Compare February 3, 2025 01:32
@dcousens dcousens marked this pull request as ready for review February 3, 2025 04:19
@dcousens
Copy link
Member Author

dcousens commented Feb 3, 2025

This pull request is pretty big, and we could probably keep working on it for quite a while, but it's time to move to the next phase and put out an RC for wider testing.

@dcousens dcousens merged commit b7d0f1b into main Feb 3, 2025
45 of 46 checks passed
@dcousens dcousens deleted the introduce-keystar-ui branch February 3, 2025 04:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants