Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added support of underscored arguments in have_field #29

Merged
merged 7 commits into from
Feb 6, 2020
Merged

Added support of underscored arguments in have_field #29

merged 7 commits into from
Feb 6, 2020

Conversation

makketagg
Copy link
Contributor

The simple solution for underscored arguments in the have_field matcher. Fixed #28

@makketagg
Copy link
Contributor Author

Hey @khamusa. Can we update the bundler version? On local machine works great, but the TravisCI doesn't work

Copy link
Owner

@khamusa khamusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM. I see from the commits history you tried solving the bundler issue yourself. No problem, we can update the bundler version. Let me know if you need me to do anything else.

@makketagg
Copy link
Contributor Author

makketagg commented Feb 3, 2020

@khamusa thanks for response. Probably, I found solution for ci - https://docs.travis-ci.com/user/languages/ruby/

If you are using Ruby 2.3.x but wish to explicitly stay on Bundler 1.x (e.g., for dependency reasons such as Rails 4.2.x), write:

before_install:
  - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
  - gem install bundler -v '< 2'

Let's try

UPD
Doesn't work

Gem bundler-2.1.2 cannot be uninstalled because it is a default gem

Upgraded bundler version

@khamusa khamusa merged commit d92d33c into khamusa:master Feb 6, 2020
@makketagg makketagg deleted the add/underscored-arguments-support branch February 6, 2020 22:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert :field_name to 'fieldName' automaticallly
2 participants