Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for underscored argument names in accept_argument(s) #32

Merged
merged 1 commit into from
May 7, 2020

Conversation

TonyArra
Copy link
Contributor

@TonyArra TonyArra commented May 2, 2020

Allows for underscored argument names in the accept_argument and accept_arguments matchers.

@TonyArra TonyArra force-pushed the accept-snakecased-args branch from 64af8d4 to 3f3bbef Compare May 2, 2020 00:55
@TonyArra TonyArra changed the title Add support for camelized argument name in accept_argument Add support for underscored argument name in accept_argument May 2, 2020
@TonyArra TonyArra force-pushed the accept-snakecased-args branch from 3f3bbef to b83d89e Compare May 2, 2020 02:10
@TonyArra TonyArra changed the title Add support for underscored argument name in accept_argument Add support for underscored argument names in accept_argument(s) May 2, 2020
@khamusa
Copy link
Owner

khamusa commented May 4, 2020

Hey @TonyArra, thanks for the Pull Request! I'll take some time to look at this as soon as possible. In the meanwhile, can you fix the codeclimate issues for too long lines? Thx!

@TonyArra
Copy link
Contributor Author

TonyArra commented May 4, 2020

Hey @TonyArra, thanks for the Pull Request! I'll take some time to look at this as soon as possible. In the meanwhile, can you fix the codeclimate issues for too long lines? Thx!

Hey @khamusa, I see that the Travis build passed, and there's a Details link to view the build. but for codeclimate, all I see is "codeclimate Expected — Waiting for status to be reported" with no link. Is there a way for me see the codeclimate issues?

@TonyArra TonyArra force-pushed the accept-snakecased-args branch from b83d89e to 13b82ba Compare May 4, 2020 21:49
@TonyArra
Copy link
Contributor Author

TonyArra commented May 4, 2020

@khamusa I was able to analyze the branch on my fork and fixed the issues

Copy link
Owner

@khamusa khamusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TonyArra! Looks good to me, I'll review your other PRs, and after testing the result if everything is ok I'll release a new version.

@khamusa khamusa merged commit 9c18b03 into khamusa:master May 7, 2020
@TonyArra TonyArra deleted the accept-snakecased-args branch May 7, 2020 18:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants