Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Fix: clippy::from_over_into errors. #1

Merged
merged 1 commit into from
May 6, 2021
Merged

Fix: clippy::from_over_into errors. #1

merged 1 commit into from
May 6, 2021

Conversation

MouseProducedGames
Copy link
Contributor

This is a quick conversion of Into trait impls to From trait impls, to fix the "clippy::from_over_into" errors. Although it passes clippy, it may still have errors.

@kl-botsu
Copy link

kl-botsu commented May 4, 2021

CLA assistant check
All committers have signed the CLA.

@ecton
Copy link
Member

ecton commented May 4, 2021

Thank you for submitting this PR! I am shocked and elated that someone else is finding this library useful. Because I'm trying to build a business with these libraries, I, unfortunately, require contributors to sign a contributor license agreement to protect myself legally. If you're not willing to, I still sincerely appreciate your pull request, and I will reimplement this myself in an update.

On an unrelated note, I'm excited to get this library updated to the recently released wgpu 0.8. I am hoping to look into that within a week or two -- I'm currently deep into another project and want to get a bit more done before switching contexts again.

@MouseProducedGames
Copy link
Contributor Author

MouseProducedGames commented May 4, 2021

I have signed the CLA.
If you are wondering who "MouseProducedGames" is, that's a name for my indie development stuff consisting of me, myself, and I. ;)

@ecton ecton merged commit b316c67 into khonsulabs:main May 6, 2021
@ecton
Copy link
Member

ecton commented May 6, 2021

I finally had a chance to make sure nothing I had downstream would break from this (I couldn't imagine it would have). As I hoped, everything still compiled. Thank you for contributing!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants