[NT-721] Updating Project Page Viewed event timing #1005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Updates the logic of when the
Project Page Viewed
event fires so that we can track all project properties.🤔 Why
Previously, we were firing the
Project Page Viewed
event right when the project page is configured. Because we prefix thefetchProject
request with a partial project object, theProject Page Viewed
event was being sent with incompleteprojectProperties
.Now, we wait for the
fetchProject
request to complete with the full project object before we track theProject Page Viewed
event -- this allows us to send the event with all project properties.🛠 How
Shuffling around the view model logic for the
Project Page Viewed
event.✅ Acceptance criteria
Make sure you have the
KOALA_TRACKING
environment variable set totrue
Project Page Viewed
event fire with the following properties populated:project_rewards_count
// should not be zeroproject_updates_count
project_comments_count
Project Page Viewed
event should fire again.