Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[NT-796] Fix sheet overlay on iOS 13 #1067

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Conversation

justinswart
Copy link
Contributor

@justinswart justinswart commented Feb 13, 2020

📲 What

  • Fixes the presentation of the SheetOverlayTransitionAnimator on iOS 13 so that the view extends beyond the safe area.
  • Uses default modal presentation on iOS 13 for the login and add new card modals during checkout.

🤔 Why

This was a regression noticed after updating to iOS 13. The default modal presentation style is sufficient in 2 of 3 places that we use the SheetOverlayViewController, however for the presentation of the PledgeShippingLocationViewController we still need it for the custom vertical offset behaviour.

🛠 How

  • Fixed the frame sizes in SheetOverlayTransitionAnimator.
  • Added #available checks for iOS 13 to default to the built-in modal for that OS version.

👀 See

iOS 12 iOS 13 iOS 13 login
image image image

✅ Acceptance criteria

iPhone running iOS 12.4:
iPad running iOS 12.4 or iOS 13.x.

  • Tapping continue on pledge view when logged out presents login modal using SheetOverlayViewController.
  • Tapping add new card on pledge view presents AddNewCardViewController using SheetOverlayViewController.
  • Selecting a shipping method presents PledgeShippingLocationViewController using SheetOverlayViewController.

iPhone running iOS 13.x:

  • Tapping continue on pledge view when logged out presents login modal using the standard modal presentation style.
  • Tapping add new card on pledge view presents AddNewCardViewController the standard modal presentation style.
  • Selecting a shipping method presents PledgeShippingLocationViewController using SheetOverlayViewController.

@justinswart justinswart requested a review from Scollaco February 13, 2020 01:55
@justinswart justinswart assigned Scollaco and cdolm92 and unassigned Scollaco Feb 13, 2020
@justinswart justinswart merged commit b331612 into master Feb 14, 2020
@justinswart justinswart deleted the NT-796-login-modal-bug branch February 14, 2020 19:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants