[NT-796] Fix sheet overlay on iOS 13 #1067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
SheetOverlayTransitionAnimator
on iOS 13 so that the view extends beyond the safe area.🤔 Why
This was a regression noticed after updating to iOS 13. The default modal presentation style is sufficient in 2 of 3 places that we use the
SheetOverlayViewController
, however for the presentation of thePledgeShippingLocationViewController
we still need it for the custom vertical offset behaviour.🛠 How
SheetOverlayTransitionAnimator
.#available
checks for iOS 13 to default to the built-in modal for that OS version.👀 See
✅ Acceptance criteria
iPhone running iOS 12.4:
iPad running iOS 12.4 or iOS 13.x.
SheetOverlayViewController
.AddNewCardViewController
usingSheetOverlayViewController
.PledgeShippingLocationViewController
usingSheetOverlayViewController
.iPhone running iOS 13.x:
AddNewCardViewController
the standard modal presentation style.PledgeShippingLocationViewController
usingSheetOverlayViewController
.