-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[NT-885] Landing page optimizely events #1112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added LandingPageViewController * Added LandingPageViewModel and assets * Fixed screen layout * Added LandingPageViewModelTests * SwiftFormat * Fixed comment * Feedback from Justin and Isabel * Disabled rotation, feedback from Isabel * Swiftformat * Fixed dynamic type support * SwiftFormat
…/ios-oss into feature-landing-page
…/ios-oss into feature-landing-page
ifbarrera
approved these changes
Mar 18, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Get Started
button on the Landing Page is tapped.🤔 Why
Jira ticket .
🛠 How
AppDelegateViewModel
, added the tracking client to fire wheneverapplicationDidEnterBackgroundProperty.signal
emits.LandingPageViewModel
, added the tracking client to fire wheneverctaButtonTappedSignal
emits.👀 See
✅ Acceptance criteria
App Closed
event should appear on the logs.On

AppDelegateViewModel
, add areturn true
below theshouldGoToLandingPage
function signature. This will force the Landing Page to be presented:Get Started
button. TheGet Started Button Clicked
event should appear on the logs.