Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[NT-912] Experimental read more button loading bugfix #1124

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

justinswart
Copy link
Contributor

@justinswart justinswart commented Mar 25, 2020

📲 What

Addresses a bug in which the read more button in our native_project_page_campaign_details experiment would sometimes not show the loading indicator correctly.

🤔 Why

This button is meant to display a loading indicator until the Project has been refreshed and hydrated with its rewards.

🛠 How

Removed some problematic skipRepeats() that were preventing the button from being put back into a loading state after the cell was reused by the table view.

✅ Acceptance criteria

Using link conditioner, charles, airplane mode, or your favourite method of breaking your internet connectivity, put yourself in variants 1 or 2 of the native_project_page_campaign_details experiment. Navigate to a project.

  • In variant 2 observe that if the project refresh errors, the read more button remains spinning and disables to taps.
  • In variant 1 observe that the button is tappable without a loading indicator.
  • In all scenarios of variant 2, the read more button should not cause the view to freeze or be tappable until rewards have been refreshed.

Copy link
Contributor

@ifbarrera ifbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! ⭐️ A tricky one to be sure.

@justinswart justinswart merged commit 95c0cfc into master Mar 26, 2020
@justinswart justinswart deleted the NT-912-read-more-button-bugfix branch March 26, 2020 16:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants