-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[NT-1023] Add Temporary Checkout Completed event #1127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the Optimizely functions! Testing the event now 🙏
@@ -1202,6 +1207,40 @@ final class PledgeViewModelTests: TestCase { | |||
["Checkout Payment Page Viewed"], | |||
self.trackingClient.events | |||
) | |||
|
|||
XCTAssertEqual(optimizelyClient.trackedUserId, "DEADBEEF-DEAD-BEEF-DEAD-DEADBEEFBEEF") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it might be nicer to create a separate test for the optimizely events? That way when we remove the experiment we can just delete the test 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm from what I can tell! Merge at your discretion.
📲 What
Temporary Checkout Completed
to be sent to Optimizely once a checkout completes.🤔 Why
Checkout Completed
event is not tracking correctly from the back-end. We are using this event as a temporary workaround for reasons.🛠 How
👀 See
Example JSON that is posted to Optimizely for this event:
✅ Acceptance criteria
Place yourself in an experimental variant on Optimizely, complete a checkout with a credit card and with Apple Pay. Observe the following for both:
checkout_payment_type
changes toAPPLE_PAY
when using that payment method).