Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[NT-1203] Lights On Editorial Collection #1197

Merged
merged 9 commits into from
May 27, 2020

Conversation

justinswart
Copy link
Contributor

@justinswart justinswart commented May 15, 2020

📲 What

Lights On Editorial Collection Feature. Includes the following PRs:

#1185, #1194, #1196, #1208

👀 See

cdolm92 and others added 4 commits May 14, 2020 10:52
* wip

* new copy

* new snapshots

* swift format

* remove old code

* corrected test

* translated copy

* reused cell

* swift format

* pr feedback

* smapshot tests

* correct image
…1194)

* wip

* new copy

* new snapshots

* swift format

* remove old code

* corrected test

* new copy

* translated copy

* reused cell

* swift format

* wip

* wip

* pr feedback

* smapshot tests

* snapshots

* delete file

* removed copy

* missing copy

* snapshots

* swift format

* changed tag id

* sorted by distance

* test refactor

* fix test

* Tidy up

* Fix icon

* Snapshots

Co-authored-by: Justin Swart <justinswart@users.noreply.github.com>
@nativeksr
Copy link
Collaborator

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

* Add Optimizely lights on feature flag, remove Go Rewardless references

* Snapshots

* Formatting

* Remove extra underscore

* Remove table view header, fix typo, update snapshots

* Oops
# Conflicts:
#	Library/ViewModels/DiscoveryPageViewModelTests.swift
* Add Optimizely lights on feature flag, remove Go Rewardless references

* Snapshots

* Formatting

* Remove extra underscore

* Remove table view header, fix typo, update snapshots

* Oops

* Update copy

* Fix tests

* Fix layout
@justinswart justinswart requested a review from ifbarrera May 26, 2020 21:01
@justinswart justinswart marked this pull request as ready for review May 26, 2020 21:01
Copy link
Contributor

@ifbarrera ifbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@justinswart justinswart merged commit 27848b3 into master May 27, 2020
@justinswart justinswart deleted the NT-1203-lights-on-editorial-collection branch May 27, 2020 15:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants