[NT-1256] iOS 12 pledge screen scroll view insets bug #1198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixes a bug in iOS 12 where presenting a VC from the pledge screen caused the scroll view insets to be reset to zero, which caused the pledge button container to overlap some content near the bottom of the screen.
🤔 Why/How
This was a strange one. For some reason on iOS 12.4, presenting a VC on top of a scroll view with its
contentInsetAdjustmentBehavior
set toautomatic
(the default), caused the content insets to abruptly be reset back to zero when the presented VC is dismissed. Strangely, examining thecontentInsets
after the dismissal showed that theadjustedContentInsets
were still correctly set, but visually the scroll view appeared to have anadjustedContentInset
of.zero
. Setting thecontentInsetAdjustmentBehavior
on therootScrollView
to.zero
seemed to fix the issue, but it caused a strange side effect where the scroll view no longer bounced properly.As a workaround, this PR pins the
rootScrollView
'sbottom
to the top of thepledgeCTAContainerView
so we don't rely on thecontentInsets
being correct.👀 See
Trello, screenshots, external resources?
✅ Acceptance criteria